Skip to content

add prodigy deps #11564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add prodigy deps #11564

wants to merge 1 commit into from

Conversation

crapthings
Copy link

add missing optimizer deps for beginner

@linoytsaban
Copy link
Collaborator

hey @crapthings, we try to keep the dependencies as minimal as possible, and since training with prodigy is optional (and the default is AdamW) we kept it out of the requirements and raise this error:

if args.optimizer.lower() == "prodigy":
try:
import prodigyopt
except ImportError:
raise ImportError("To use Prodigy, please install the prodigyopt library: `pip install prodigyopt`")

however I see how this may lead to some frustration so we perhaps could add a note to the README to make sure to install prodigyopt if you wish to use prodigy.
cc @sayakpaul @asomoza

@sayakpaul
Copy link
Member

Yeah having installation instructions is the best we can do IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants